Re: Support custom socket directory in pg_upgrade - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Support custom socket directory in pg_upgrade
Date
Msg-id 23026.1542984307@sss.pgh.pa.us
Whole thread Raw
In response to Re: Support custom socket directory in pg_upgrade  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Support custom socket directory in pg_upgrade
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 12/11/2018 20:00, Tom Lane wrote:
>>> Also, even if we had an arguably-better idea, I suspect that there would
>>> always be cases where it didn't work.

> Surely they can just set TMPDIR if /tmp is not writable?  If TMPDIR is
> set and not writable, bark at the user for it.

(1) There was nothing about TMPDIR in Peter's proposal, nor would an
implementation based on mkdtemp(3) automatically do that for us.

(2) If you accept the proposition that we must provide a user knob of
some sort, why shouldn't it be a command line switch rather than an
environment variable?  The former are much easier to document and to
discover.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: row filtering for logical replication
Next
From: Konstantin Knizhnik
Date:
Subject: Index-only scan is slower than Index scan.