Re: pg_restore ignores -C when using a restore list -L - Mailing list pgsql-bugs

From Tom Lane
Subject Re: pg_restore ignores -C when using a restore list -L
Date
Msg-id 22850.1273685964@sss.pgh.pa.us
Whole thread Raw
In response to pg_restore ignores -C when using a restore list -L  (Russell Smith <mr-russ@pws.com.au>)
Responses Re: pg_restore ignores -C when using a restore list -L  (Russell Smith <mr-russ@pws.com.au>)
List pgsql-bugs
Russell Smith <mr-russ@pws.com.au> writes:
> pg_restore silently ignores the inclusion of -C when you do use a
> restore list.

It would work as you expect if you use -C when creating the list file.
The reason for this is that -C basically means "don't skip the DATABASE
entry".  When you use -l without -C, you get a list file that doesn't
include the DATABASE entry.  In the last step, you need both -C and
the DATABASE entry listed in the list file in order to have the CREATE
DATABASE command emitted.

We could possibly "fix" this by emitting the DATABASE entry during -l
with or without -C.  I'm not sure if that would have any bad side
effects, but a quick test suggests that it will still skip the DATABASE
entry if it's listed in the list file but -C isn't given.  Of course,
if you manually remove the DATABASE entry from the list file, you lose
anyway.

            regards, tom lane

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #5459: Unable to cancel query while in send()
Next
From: Rumko
Date:
Subject: Bug report (#5456) not showing up on the ML