Re: Further patch for VS2005 - Mailing list pgsql-patches

From Tom Lane
Subject Re: Further patch for VS2005
Date
Msg-id 22740.1151354831@sss.pgh.pa.us
Whole thread Raw
In response to Further patch for VS2005  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: Further patch for VS2005  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-patches
"Magnus Hagander" <mha@sollentuna.net> writes:
> *** src/pl/plpython/plpython.c    25 Jun 2006 00:18:24 -0000    1.83
> --- src/pl/plpython/plpython.c    26 Jun 2006 13:58:56 -0000
> ***************
> *** 10,16 ****
> --- 10,19 ----
>   /* Python uses #pragma to bring in a non-default libpython on VC++ if
>    * _DEBUG is defined */
>   #undef _DEBUG
> + /* Also hide away errcode, since we load Python.h before postgres.h */
> + #define errcode __vc_errcode
>   #include <Python.h>
> + #undef errcode
>   #define _DEBUG
>   #else
>   #include <Python.h>

BTW, it strikes me as a fairly bad idea to be including <Python.h>
first; that goes directly against the conventions we established to be
sure that largefile support doesn't break.  Has anyone looked into
making plpython.c conform to project standards by including postgres.h
first?

            regards, tom lane

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Further patch for VS2005
Next
From: "Magnus Hagander"
Date:
Subject: Re: Further patch for VS2005