Re: small exclusion constraints patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: small exclusion constraints patch
Date
Msg-id 22686.1274469875@sss.pgh.pa.us
Whole thread Raw
In response to small exclusion constraints patch  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: small exclusion constraints patch
List pgsql-hackers
Jeff Davis <pgsql@j-davis.com> writes:
> Currently, the check for exclusion constraints performs a sanity check
> that's slightly too strict -- it assumes that a tuple will conflict with
> itself. That is not always the case: the operator might be "<>", in
> which case it's perfectly valid for the search for conflicts to not find
> itself.

> This patch simply removes that sanity check, and leaves a comment in
> place.

I'm a bit uncomfortable with removing the sanity check; it seems like a
good thing to have, especially since this code hasn't even made it out
of beta yet.  AFAIK the "<>" case is purely hypothetical, because we
have no index opclasses supporting such an operator, no?  How about just
documenting that we'd need to remove the sanity check if we ever did add
support for such a case?
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Greg Sabino Mullane"
Date:
Subject: Re: changed source files.
Next
From: David Fetter
Date:
Subject: Re: Specification for Trusted PLs?