Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql-server: Add ALTER INDEX, particularly for moving tablespaces. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.
Date
Msg-id 22431.1093108875@sss.pgh.pa.us
Whole thread Raw
In response to pgsql-server: Add ALTER INDEX, particularly for moving tablespaces.  (momjian@svr1.postgresql.org (Bruce Momjian))
Responses Re: pgsql-server: Add ALTER INDEX, particularly for moving
Re: pgsql-server: Add ALTER INDEX, particularly for
List pgsql-committers
Tree view 
momjian@svr1.postgresql.org (Bruce Momjian) writes:
> Add ALTER INDEX, particularly for moving tablespaces.

This patch is a perfect example of why unreviewed patches should not
go in during beta.

So far I have noticed the following problems with it:

* Added reference page wasn't linked into the docs build.

* Added a field to struct AlterTableStmt, but did not do the necessary
  housekeeping for extending a Node (eg, copyfuncs and equalfuncs
  adjustments), nor make sure the field is validly set in every place
  an AlterTableStmt is constructed.

* ALTER INDEX RENAME doesn't actually work.

regression=# alter index foo_pkey rename to zzz;
ERROR:  unrecognized rename stmt type: 9

That's not counting the problem someone else already reported with
incorrect tab-completion.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server: Seems it would be nice if the ALTER INDEX ref page were
Next
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server: Fix tab completion for ALTER INDEX.