Re: pg_test_fsync crashes on systems with POSIX signal handling - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_test_fsync crashes on systems with POSIX signal handling
Date
Msg-id 22388.1363576248@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_test_fsync crashes on systems with POSIX signal handling  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Fri, Mar 15, 2013 at 03:05:54PM -0400, Tom Lane wrote:
>> The quick-and-dirty fix for this is to just copy pqsignal() into
>> pg_test_fsync, and use that instead of calling signal() directly.
>> I wonder though if we shouldn't move that function into libpgport.
>> Thoughts?

> Well, the Win32 signal handler is already in port, so moving the Unix
> one seems to make sense, i.e. the comment above pgsignal says:
>     /* Win32 signal handling is in backend/port/win32/signal.c */

Done, though it was a bit more painful than I expected --- I seem to
have guessed completely wrong about where the portability hazards were.
Good thing we have a buildfarm.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [v9.3] OAT_POST_ALTER object access hooks
Next
From: robins
Date:
Subject: Patch to add regression tests for SCHEMA