Re: Solaris "sed" versus pre-v13 plpython tests - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Solaris "sed" versus pre-v13 plpython tests
Date
Msg-id 222938.1661993842@sss.pgh.pa.us
Whole thread Raw
In response to Solaris "sed" versus pre-v13 plpython tests  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I wrote:
> I confirmed on the gcc farm's Solaris 11 box that the pattern
> doesn't work as expected with /usr/bin/sed:

> tgl@gcc-solaris11:~$ echo except foo, bar: | sed -e 's/except \([[:alpha:]][[:alpha:].]*\),
*\([[:alpha:]][[:alpha:]]*\):/except\1 as \2:/g' 
> except foo, bar:

> We could perhaps do this instead:

> $ echo except foo, bar: | sed -e '/^ *except.*,.*: *$/s/, / as /g'
> except foo as bar:

> It's a little bit more brittle, but Python doesn't allow any other
> commands on the same line does it?

Oh ... after a bit more experimentation, there's an easier way.
Apparently the real problem is that Solaris' sed doesn't handle
[[:alpha:]] (I wonder if this is locale-dependent?).  I get
correct results after expanding it manually, eg

tgl@gcc-solaris11:~$ echo except foo, bar: | sed -e 's/except \([a-z][a-z.]*\), *\([a-z][a-zA-Z]*\):/except \1 as
\2:/g'
except foo as bar:

We aren't likely to need anything beyond a-zA-Z and maybe 0-9,
so I'll go fix it that way.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: pg15b3: recovery fails with wal prefetch enabled
Next
From: Michael Paquier
Date:
Subject: Re: Support tls-exporter as channel binding for TLSv1.3