Re: [PATCH] Formatting patch for psql - Mailing list pgsql-patches

From Tom Lane
Subject Re: [PATCH] Formatting patch for psql
Date
Msg-id 22120.1132930701@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Formatting patch for psql  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: [PATCH] Formatting patch for psql
List pgsql-patches
Martijn van Oosterhout <kleptog@svana.org> writes:
> ... There is a fair
> bit of encoding code in there already but the information you need here
> is specifically: is this char a control character and in particular, is
> it a newline.

The appropriate test for that is just "ch == '\n'", in all the encodings
we support (although you do have to be careful that ch isn't a non-first
byte of a multibyte character).  If that's all you need then inventing
a bunch of additional infrastructure is really inappropriate.

            regards, tom lane

pgsql-patches by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: Re: [PATCH] Formatting patch for psql
Next
From: "Pavel Stehule"
Date:
Subject: is not distinct from