Re: Fix for VACUUM in psql autocommit off - Mailing list pgsql-patches

From Tom Lane
Subject Re: Fix for VACUUM in psql autocommit off
Date
Msg-id 22029.1095626662@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fix for VACUUM in psql autocommit off  ("Michael Paesold" <mpaesold@gmx.at>)
List pgsql-patches
"Michael Paesold" <mpaesold@gmx.at> writes:
>  Or do I not understand what you mean by nested
> comments? (There is code for ignore /* .. */ before the first keyword.)

Per SQL spec, the backend thinks that /* .. */ nests:

regression=# /* some /* comment */ comment */ select 1;
 ?column?
----------
        1
(1 row)

As it stands, is_transact_command will get confused by this.

> Any suggestion how to that? I can think of a way myself, but it may not be
> the best, as I don't consider C my natural language. I can try, or does
> anyone else feel inclined to fix this?

I'd split out the code that locates "the next keyword" into a separate
function that could be called twice.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Michael Paesold"
Date:
Subject: Re: Fix for VACUUM in psql autocommit off
Next
From: "Michael Paesold"
Date:
Subject: Re: Fix for VACUUM in psql autocommit off