Re: proposal: a validator for configuration files - Mailing list pgsql-hackers

From Alexey Klyukin
Subject Re: proposal: a validator for configuration files
Date
Msg-id 21F3A21F-FAB1-4E8F-BDA8-B9793157A013@commandprompt.com
Whole thread Raw
In response to Re: proposal: a validator for configuration files  (Alexey Klyukin <alexk@commandprompt.com>)
Responses Re: proposal: a validator for configuration files  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Apr 1, 2011, at 12:08 AM, Alexey Klyukin wrote:

> Hi Selena,
>
> On Mar 30, 2011, at 11:42 PM, Selena Deckelmann wrote:
>
>> Hi!
>>
>> On Wed, Mar 30, 2011 at 8:40 AM, Alexey Klyukin <alexk@commandprompt.com> wrote:
>>
>>
>> I did a little bit of work on this, and we discussed it here:
>>
>> http://archives.postgresql.org/pgsql-hackers/2009-03/msg00345.php
>> http://archives.postgresql.org/pgsql-hackers/2009-03/msg01142.php
>>
>> Probably there's a bit of bitrot in there.
>
> Cool, I was not aware of your work in this direction. I've updated your patch
> to apply to the latest HEAD, implementing Tom Lane's suggestions (attached). I
> think I'll implement the other part (reporting all invalid parameters, as
> opposed to only the first one) tomorrow.

Here's the update of Selena's patch, which also shows all errors in
configuration parameters (as well as parser errors) during reload.

When I talked to Alvaro the other day he suggested starting with a stand-alone
process, which would load the postgresql.conf in a postmaster context, load
other configuration files and do some of the checks I've mentioned in my
initial proposal (particularly it would check that system's shared memory
limit is high enough by trying to allocate a new shared memory segment).
Afterwards, I'd like to implement checks from a user-callable function, and
not all checks would be available from it.

--
Alexey Klyukin
The PostgreSQL Company - Command Prompt, Inc.





Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: GUC assign hooks (was Re: wal_buffers = -1 and SIGHUP)
Next
From: Andrew Dunstan
Date:
Subject: Re: small fix for Windows build