Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove one TimestampTzGetDatum call in pg_stat_get_io() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Remove one TimestampTzGetDatum call in pg_stat_get_io()
Date
Msg-id 2195866.1725633498@sss.pgh.pa.us
Whole thread Raw
Responses Re: Remove one TimestampTzGetDatum call in pg_stat_get_io()
List pgsql-hackers
Tree view 
Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> While working on the per backend I/O statistics patch ([1]), I noticed that
> there is an unnecessary call to TimestampTzGetDatum() in pg_stat_get_io() (
> as the reset_time is already a Datum).

Hmm, TimestampTzGetDatum is not a no-op on 32-bit machines.  If you're
correct about this, why are our 32-bit BF animals not crashing?  Are
we failing to test this code?

            regards, tom lane

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
Next
From: Tom Lane
Date:
Subject: Re: Remove one TimestampTzGetDatum call in pg_stat_get_io()