Re: serverlog rotation/functions - Mailing list pgsql-patches

From Tom Lane
Subject Re: serverlog rotation/functions
Date
Msg-id 21956.1089775386@sss.pgh.pa.us
Whole thread Raw
In response to Re: serverlog rotation/functions  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Now that I understand Andreas's patch, and the way he is using shared
> memory to store only the timestamp, and how he checks shared memory on
> every elog call, I no longer see problems with his method.

The fundamentally unfixable problem with his method is that it can only
capture elog output, not stderr output from libraries that we don't
control (the dynamic linker being the biggest case, but there are
others).

I do not have any faith in the method as regards to switchover
reliability or message synchronization, either.  I'm prepared to
grant that those might be only minor problems ... but I don't really see
why we should put up with doubts in this area.  When you want to look at
a server log, it's because you are trying to debug a problem.  The very
last thing you need is any niggling doubts about whether what you are
reading is the truth.

Finally, I simply do not trust *any* dependency on shared memory in this
connection.  Again, I'm sure it works great in the normal case, but the
normal case is not what you need a server log for.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: serverlog rotation/functions
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Is "trust" really a good default?