Re: [HACKERS] For review: Server instrumentation patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] For review: Server instrumentation patch
Date
Msg-id 21919.1123873313@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] For review: Server instrumentation patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
I wrote:
> I'm not sure whether to export skip_drive from path.c or just duplicate
> it.  If we do export it, a different name would probably be a good idea,
> as it seems too generic for a global symbol.

On reflection, there's another possibility, which is to put the test
code into path.c in the first place, defined something like

bool path_contains_parent_reference(const char *path);

This is probably better since the whole business of looking for ".."
seems like something that should be in path.c and not elsewhere.

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] data on devel code perf dip
Next
From: Tom Lane
Date:
Subject: Re: Bug in canonicalize_path()