Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] btree_gist: fix union implementation for variable length columns - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] btree_gist: fix union implementation for variable length columns
Date
Msg-id 21877.1531158119@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] btree_gist: fix union implementation for variable length columns  (Pavel Raiskup <praiskup@redhat.com>)
Responses Re: [PATCH] btree_gist: fix union implementation for variable length columns  (Pavel Raiskup <praiskup@redhat.com>)
List pgsql-hackers
Tree view 
Pavel Raiskup <praiskup@redhat.com> writes:
> while I tried to debug 'gcc -fstack-protector -O3' problems in [1], I noticed
> that gbt_var_union() mistreats the first vector element.  Patch is attached.

Hi Pavel!  For patches that purport to resolve bugs, we usually like to
add a regression test case that demonstrates the bug in unpatched code.
Can you provide a small test case that does so?  (The BZ you pointed to
doesn't seem to address this...)

            regards, tom lane

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Locking B-tree leafs immediately in exclusive mode
Next
From: Andrey Borodin
Date:
Subject: Re: [HACKERS] [PATCH] kNN for SP-GiST