Re: Question about an inconsistency - 2 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Question about an inconsistency - 2
Date
Msg-id 21868.1468975027@sss.pgh.pa.us
Whole thread Raw
In response to Question about an inconsistency - 2  ("petrum@gmail.com" <petrum@gmail.com>)
List pgsql-hackers
"petrum@gmail.com" <petrum@gmail.com> writes:
> In file postgresql-9.4.4/src/backend/utils/adt/format_type.c
> function format_type_internal line 159, shouldn’t be used
> array_base_type instead of type_oid?

IIRC, that was intentional.  Supposing there's a pg_type row with
a corrupted typelem value, it's more useful to point at the bogus
row than to report the junk value with no context.  I suppose you
could argue that it should be more like
elog(ERROR, "cache lookup failed for type %u (typelem of %u)",     array_base_type, type_oid);
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [BUG] pg_basebackup from disconnected standby fails
Next
From: Tom Lane
Date:
Subject: Re: Question about an inconsistency - 3