Re: [BUG] pg_stat_statements and extended query protocol - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [BUG] pg_stat_statements and extended query protocol
Date
Msg-id 2173371.1680730753@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUG] pg_stat_statements and extended query protocol  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [BUG] pg_stat_statements and extended query protocol
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Apr 05, 2023 at 04:07:21AM +0000, Imseih (AWS), Sami wrote:
>> Attached is v5 addressing the comments.

> Thanks, this should be enough to persist the number of tuples tracked
> across multiple ExecutorRun() calls.  This looks pretty good to me.

v5 seems OK to me except I think CreateExecutorState() should explicitly
zero the new es_total_processed field, alongside zeroing es_processed.
(I realize that the makeNode would have done it already, but our
coding conventions generally run towards not relying on that.  This is
mainly for greppability, so you can find where a field is initialized.)

            regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
Next
From: Daniel Gustafsson
Date:
Subject: Re: Making background psql nicer to use in tap tests