Re: [PATCH] Prevent pg_dump running out of memory - Mailing list pgsql-patches

From Tom Lane
Subject Re: [PATCH] Prevent pg_dump running out of memory
Date
Msg-id 21677.998944610@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] Prevent pg_dump running out of memory  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: [PATCH] Prevent pg_dump running out of memory
List pgsql-patches
Martijn van Oosterhout <kleptog@svana.org> writes:
> This patch replaces the simple SELECT * with a cursor that fetches 1,000 rows
> at a time. The 1,000 was chosen because it was small enough to test but I
> think realisitically 10,000 wouldn't be too much.

Applied.  However, I went the other way: I reduced the 1000 to 100.
I doubt it'll make much difference in performance, and with TOAST
available I can believe people might have multi-megabyte rows.

I also added a cursor CLOSE command, just to be a neatnik.  It's
probably not critical given that the same cursor name is used each
time, but still...

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Makefiles for building with mingw32 on win32
Next
From: Tom Lane
Date:
Subject: Expect slow response this week