Re: windows cfbot failing: my_perl - Mailing list pgsql-hackers

From Tom Lane
Subject Re: windows cfbot failing: my_perl
Date
Msg-id 2167247.1661569326@sss.pgh.pa.us
Whole thread Raw
In response to Re: windows cfbot failing: my_perl  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: windows cfbot failing: my_perl
Re: windows cfbot failing: my_perl
List pgsql-hackers
John Naylor <john.naylor@enterprisedb.com> writes:
> On Sat, Aug 27, 2022 at 4:15 AM Andres Freund <andres@anarazel.de> wrote:
>> I think it'd also be needed in hstore_plperl.c, jsonb_plperl.c. Putting the
>> include in plperl.h would keep that aspect transparent, because plperl_utils.h
>> includes plperl.h.

> Since plperl_helpers.h already includes plperl.h, I'm not sure why
> both are included everywhere the former is. If .c/.xs files didn't
> include plperl.h directly, we could keep pg_wchar.h in
> plperl_helpers.h. Not sure if that's workable or any better...

Maybe we should flush the separate plperl_helpers.h header and just
put those static-inline functions in plperl.h.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Use array as object (src/fe_utils/parallel_slot.c)
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Add native windows on arm64 support