Re: New "single" COPY format - Mailing list pgsql-hackers

From Joel Jacobson
Subject Re: New "single" COPY format
Date
Msg-id 216005e5-dda1-4b46-859f-e9f235d4b5df@app.fastmail.com
Whole thread Raw
In response to Re: New "single" COPY format  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
On Thu, Dec 19, 2024, at 07:48, jian he wrote:
> I have reviewed v21-0001 again.
>
> v21-0001-Introduce-CopyFormat-and-replace-csv_mode-and-binary.patch
> is a good refactor.
>
>
> overall looks good to me.

OK, I could submit it as a separate patch.

Would we also want the reorganization of existing copy option validations?
That is, v21-0003-Reorganize-option-validations.patch minus v21-0002-Add-COPY-format-list.patch.
Nice that you managed to arrange them in the same order as in the documentation. Made the code easier to follow.

/Joel



pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: Fix bank selection logic in SLRU
Next
From: Yura Sokolov
Date:
Subject: Re: Fix bank selection logic in SLRU