Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)
Date
Msg-id 2137765.1623459379@sss.pgh.pa.us
Whole thread Raw
In response to Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> OK, I came up with the attached patch.  This is one of the few cases
> where the incompatibility is not clearly related to the feature, so I
> left the existing item alone and just created a new one with the same
> commit message in the incompatibilities section.

I think phrasing this as though user-defined aggregates are the only
pain point is incorrect.  For example, a custom operator based on
array_cat would have issues too.

I suggest a treatment more like

    Some built-in array-related functions changed signature (Tom Lane)

    Certain functions were redefined to take anycompatiblearray instead
    of anyarray.  While this does not affect ordinary calls, it does
    affect code that directly names these functions along with their
    argument types; for example, custom aggregates and operators based
    on these functions.  The affected functions are [ blah, blah ]


            regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)
Next
From: Tom Lane
Date:
Subject: Re: array_cat anycompatible change is breaking xversion upgrade tests (v14 release notes)