Re: [BUGS] BUG #6034: pg_upgrade fails when it should not. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
Date
Msg-id 21309.1306948863@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [BUGS] BUG #6034: pg_upgrade fails when it should not.
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
>>> I think you misread what I wrote, or I misexplained it, but never
>>> mind.  Matching locale names case-insensitively sounds reasonable to
>>> me, unless someone has reason to believe it will blow up.

> On FreeBSD, locale names appear to be case-sensitive:

> $ LC_ALL=en_US.UTF-8 locale charmap
> UTF-8

> $ LC_ALL=en_US.utf-8 locale charmap
> US-ASCII

Hm, surely the latter result indicates that "en_US.utf-8" is not in fact
a valid locale name?

It would only be a problem if different case-foldings of the same name
represented valid but different locales on some platform, and that seems
rather hard to believe (it would be a pretty foolish choice no?).

So I'm inclined to leave the code alone.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: patch for new feature: Buffer Cache Hibernation
Next
From: Andrew Dunstan
Date:
Subject: Re: [DOCS] DOCS: SGML identifier may not exceed 44 characters