Re: cast pid_t to int when using *printf - Mailing list pgsql-patches

From Tom Lane
Subject Re: cast pid_t to int when using *printf
Date
Msg-id 21288.1096035202@sss.pgh.pa.us
Whole thread Raw
In response to Re: cast pid_t to int when using *printf  (Neil Conway <neilc@samurai.com>)
Responses Re: cast pid_t to int when using *printf  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> I guess it would be safest to use %ld and cast pid_t to long. Of course,
> this seems a little paranoid -- is there actually a system with
> sizeof(pid_t) != 4?

Traditionally PIDs fit in 16 bits, let alone 32.  I'd recommend that we
standardize on casting pid_t to int for printing purposes; I think
that's what's being done in more places than not.  Also, as you note, we
are using int variables to hold PIDs in many places --- I don't think
it's worth running around and changing those either.

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: cast pid_t to int when using *printf
Next
From: Kris Jurka
Date:
Subject: Code/comment cleanups now that odbc is gone.