Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal - Mailing list pgsql-patches

From Tom Lane
Subject Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal
Date
Msg-id 21006.999569849@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch for pl/tcl Tcl_ExternalToUtf and  (Tatsuo Ishii <t-ishii@sra.co.jp>)
Responses Re: Patch for pl/tcl Tcl_ExternalToUtf and  (Tatsuo Ishii <t-ishii@sra.co.jp>)
List pgsql-patches
Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> But if the config switch was removed, Tcls prior 8.1 would not be
> supported at all, no?

No, Peter wasn't proposing removing #if's from the code.  His thought
is that the #if's should be conditional only on Tcl version --- if you
have a Tcl version that does UTF, then you get the translation code.

Of course, there are some issues here about compiling against a
different set of Tcl headers than you later run against, but I think
you could get burnt by that anyway.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and
Next
From: Tatsuo Ishii
Date:
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and