Re: We need to log aborted autovacuums - Mailing list pgsql-hackers

From Tom Lane
Subject Re: We need to log aborted autovacuums
Date
Msg-id 21002.1295298492@sss.pgh.pa.us
Whole thread Raw
In response to Re: We need to log aborted autovacuums  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: We need to log aborted autovacuums  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes:
> On Mon, 2011-01-17 at 14:46 -0500, Tom Lane wrote:
>> Do we actually need a lock timeout either?  The patch that was being
>> discussed just involved failing if you couldn't get it immediately.
>> I suspect that's sufficient for AV.  At least, nobody's made a
>> compelling argument why we need to expend a very substantially larger
>> amount of work to do something different.

> I have a patch to do this BUT the log message is harder. Until we grab
> the lock we can't confirm the table still exists, so we can't get the
> name for it. The whole point of this is logging the names of tables for
> which we have failed to AV. Suggestions?

As I said before, the correct place to fix this is in autovacuum.c,
which has the table name near at hand.  If you insist on fixing it
somewhere else it's going to be very invasive.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: Bug in pg_describe_object, patch v2
Next
From: Joel Jacobson
Date:
Subject: Re: Bug in pg_describe_object, patch v2