Re: BUG #4015: uninitialized value passed as an argument to tm2timetz - Mailing list pgsql-bugs

From Ted Kremenek
Subject Re: BUG #4015: uninitialized value passed as an argument to tm2timetz
Date
Msg-id 20DE0DDC-FB70-4A33-9499-D41FC5F305BA@apple.com
Whole thread Raw
In response to Re: BUG #4015: uninitialized value passed as an argument to tm2timetz  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Mar 5, 2008, at 10:10 PM, Tom Lane wrote:

> "Ted Kremenek" <kremenek@apple.com> writes:
>> It appears that there may be a case where the function tm2timetz is
>> called
>> with an uninitialized (i.e., undefined) value passed as one of its
>> arguments
>> (actually multiple arguments are undefined).
>
> I think you're assuming DateTimeParseError() will return, which it
> will
> not (it always throws ereport(ERROR)).  Or have I missed something?
>
>             regards, tom lane

Thanks Tom.

After your comments I looked more closely at ereport.  It's a little
buried, but I can see that when errstart (wrapped by ereport) is
called with ERROR that it does not return.

Thanks for the quick response.

Ted

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #4015: uninitialized value passed as an argument to tm2timetz
Next
From: Bruce Momjian
Date:
Subject: Re: BUG #3909: src\tools\msvc\clean.bat clears parse.h file