Postgres Pro
Downloads
Home   >   mailing lists

useless argument of ATAddForeignKeyConstraint - Mailing list pgsql-hackers

From Amit Langote
Subject useless argument of ATAddForeignKeyConstraint
Date
Msg-id 209c99fe-b9a2-94f4-cd68-a8304186a09e@lab.ntt.co.jp
Whole thread Raw
Responses Re: useless argument of ATAddForeignKeyConstraint  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Hi,

While reviewing the foreign keys referencing partitioned tables patch, I
noticed that the parentConstr argument of ATAddForeignConstraint is
rendered useless by the following commit:

commit 0325d7a5957ba39a0dce90835ab54a08ab8bf762
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date:   Fri Jan 18 14:49:40 2019 -0300

    Fix creation of duplicate foreign keys on partitions

Above commit added another function specialized for recursively adding a
given foreign key constraint to partitions, so ATAddForeignConstraint is
no longer called recursively.

Maybe remove that argument in HEAD ?  Attached a patch.

Thanks,
Amit
Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Problems with plan estimates in postgres_fdw
Next
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup ignores the existing data directory permissions