Postgres Pro
Downloads
Home   >   mailing lists

Busted(?) optimization in ATAddForeignKeyConstraint - Mailing list pgsql-hackers

From Tom Lane
Subject Busted(?) optimization in ATAddForeignKeyConstraint
Date
Msg-id 20849.1579817517@sss.pgh.pa.us
Whole thread Raw
Responses Re: Busted(?) optimization in ATAddForeignKeyConstraint  (Thomas Munro <thomas.munro@gmail.com>)
Re: Busted(?) optimization in ATAddForeignKeyConstraint  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view 
I happened to notice this comment in the logic in
ATAddForeignKeyConstraint that tries to decide if it can skip
revalidating a foreign-key constraint after a DDL change:

             * Since we require that all collations share the same notion of
             * equality (which they do, because texteq reduces to bitwise
             * equality), we don't compare collation here.

Hasn't this been broken by the introduction of nondeterministic
collations?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Allow to_date() and to_timestamp() to accept localized names
Next
From: Thomas Munro
Date:
Subject: Re: Busted(?) optimization in ATAddForeignKeyConstraint