Re: fix log_min_duration_statement logic error - Mailing list pgsql-patches

From Tom Lane
Subject Re: fix log_min_duration_statement logic error
Date
Msg-id 20775.1065292389@sss.pgh.pa.us
Whole thread Raw
In response to Re: fix log_min_duration_statement logic error  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: fix log_min_duration_statement logic error
Re: fix log_min_duration_statement logic error
List pgsql-patches
Peter Eisentraut <peter_e@gmx.net> writes:
> Bruce Momjian writes:
>> LOG:  duration(secs): 0.000257
>> LOG:  duration(secs): 0.000754
>> LOG:  duration(secs): 0.008115 select * from pg_class;

> I think the units typically go after the number.

In any case, this is unnecessarily incompatible with everything else.
EXPLAIN and psql's \timing show query durations in milliseconds.  And
isn't log_min_duration_statement itself measured in milliseconds?

I would prefer to see the log entries look like

    LOG: query: select * from pg_class;
    LOG: duration: nn.nnn msec

in all cases, rather than moving information around depending on which
combination of switches happens to have caused the log entries to be
generated.  Am willing to fix the code to make this happen.

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: fix log_min_duration_statement logic error
Next
From: Alvaro Herrera
Date:
Subject: Re: more spanish updates