Re: [PATCH] get_home_path: use HOME - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] get_home_path: use HOME
Date
Msg-id 20753.1474389324@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] get_home_path: use HOME  (Rudolf Gavlas <r.stu3.1@googlemail.com>)
Responses Re: [PATCH] get_home_path: use HOME
Re: [PATCH] get_home_path: use HOME
List pgsql-hackers
Rudolf Gavlas <r.stu3.1@googlemail.com> writes:
> The usage of HOME environment variable (if set) is IMO the right,
> standard and faster way to get_home_path().

Can you provide some evidence for that claim?  I can believe "faster"
but the rest sounds like wishful thinking.

> I work in an environment, where servers are administered by people
> with different user names and identical uid (0).

I think what you have there is an incredibly badly-designed system that
can be expected to break outside software (eg, Postgres).  If we take
this patch, what's to stop someone from complaining that we broke *their*
badly-designed system that abuses the HOME variable?  I'm pretty hesitant
to touch code that's worked the same way for a decade or two on such a
basis.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied”
Next
From: Jeff Janes
Date:
Subject: Re: pageinspect: Hash index support