Re: small patch to crypt.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: small patch to crypt.c
Date
Msg-id 20363.1370795293@sss.pgh.pa.us
Whole thread Raw
In response to Re: small patch to crypt.c  (Stephen Frost <sfrost@snowman.net>)
Responses Re: small patch to crypt.c
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> Regardless, setting vuntil to some magic value that really means "it's
> actually NULL", which is what you'd need to do in order to get rid of
> that explicit check for null, doesn't strike me as a good idea.  When a
> value is null, we shouldn't be looking at the data at all.

Even aside from that, the proposed change seems like a bad idea because
it introduces an unnecessary call of GetCurrentTimestamp() in the common
case where there's no valuntil limit.  On some platforms that call is
pretty slow.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Don't downcase non-ascii identifier chars in multi-byte encoding
Next
From: "Joshua D. Drake"
Date:
Subject: Re: small patch to crypt.c