Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE

From: Tom Lane
Subject: Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE
Date: ,
Msg-id: 2035.1103841874@sss.pgh.pa.us
(view: Whole thread, Raw)
In response to: Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE  (Pailloncy Jean-Gerard)
List: pgsql-performance

Tree view

Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Pailloncy Jean-Gerard, )
 Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Josh Berkus, )
  Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Pailloncy Jean-Gerard, )
   Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Pailloncy Jean-Gerard, )
    Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Josh Berkus, )
     Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Tom Lane, )
      Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Josh Berkus, )
       Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Tom Lane, )
      Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Bruno Wolff III, )
       Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Tom Lane, )
 Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Pailloncy Jean-Gerard, )
  Re: Error in VACUUM FULL VERBOSE ANALYZE (not enough memory)  (Tom Lane, )
   Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE  (Pailloncy Jean-Gerard, )
    Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE  (Tom Lane, )
    Re: Memory leak tsearch2 VACUUM FULL VERBOSE ANALYZE  (Tom Lane, )

Pailloncy Jean-Gerard <> writes:
> I think I have a test case for 7.4.2

Try the attached patch.

It looked to me like there were some smaller leaks going on during COPY
and CREATE INDEX, which I will look into later --- but this seems to be
the problem for VACUUM FULL.

            regards, tom lane

Index: vacuum.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/commands/vacuum.c,v
retrieving revision 1.263
diff -c -r1.263 vacuum.c
*** vacuum.c    2 Oct 2003 23:19:44 -0000    1.263
--- vacuum.c    23 Dec 2004 22:37:57 -0000
***************
*** 2041,2046 ****
--- 2041,2047 ----
                          ExecStoreTuple(&newtup, slot, InvalidBuffer, false);
                          ExecInsertIndexTuples(slot, &(newtup.t_self),
                                                estate, true);
+                         ResetPerTupleExprContext(estate);
                      }

                      WriteBuffer(cur_buffer);
***************
*** 2174,2179 ****
--- 2175,2181 ----
              {
                  ExecStoreTuple(&newtup, slot, InvalidBuffer, false);
                  ExecInsertIndexTuples(slot, &(newtup.t_self), estate, true);
+                 ResetPerTupleExprContext(estate);
              }
          }                        /* walk along page */



pgsql-performance by date:

From: Pierre-Frédéric Caillaud
Date:
Subject: Re: Caching of Queries
From: "Amrit Angsusingh"
Date:
Subject: Howto Increased performace ?