Re: [HACKERS] For review: Server instrumentation patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] For review: Server instrumentation patch
Date
Msg-id 20271.1123959951@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] For review: Server instrumentation patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] For review: Server instrumentation patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: [HACKERS] For review: Server instrumentation patch  (Andreas Pflug <pgadmin@pse-consulting.de>)
List pgsql-patches
I wrote:
> I'll see about installing an initdb-time kluge to make it use OUT
> parameters.

Done:

regression=# SELECT * FROM pg_stat_file('postgresql.conf');
 length |         atime          |         mtime          |         ctime          | isdir
--------+------------------------+------------------------+------------------------+-------
  12578 | 2005-08-13 14:51:03-04 | 2005-08-13 14:50:32-04 | 2005-08-13 14:50:32-04 | f
(1 row)

I removed the separate pg_file_length() function, as it doesn't have any
significant notational advantage anymore; you can do

regression=# select (pg_stat_file('postgresql.conf')).length;
 length
--------
  12578
(1 row)

BTW, \df is no real help when it comes to stuff with OUT parameters;
it still says

regression=# \df pg_stat_file
                         List of functions
   Schema   |     Name     | Result data type | Argument data types
------------+--------------+------------------+---------------------
 pg_catalog | pg_stat_file | record           | text
(1 row)

Possibly we should try to improve that.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] For review: Server instrumentation patch
Next
From: Martijn van Oosterhout
Date:
Subject: [PATCH] Clarify issues with SPI and C language function limitations