Re: Log prefix missing for subscriber log messages received from publisher - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Log prefix missing for subscriber log messages received from publisher
Date
Msg-id 202507210851.cz7ct4ffpp76@alvherre.pgsql
Whole thread Raw
In response to Re: Log prefix missing for subscriber log messages received from publisher  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: Log prefix missing for subscriber log messages received from publisher
List pgsql-hackers
On 2025-Jul-21, Fujii Masao wrote:

> Thanks for updating the patch! It looks good to me, except for one minor point:
> 
>  static inline PGresult *libpqsrv_get_result(PGconn *conn, uint32 wait_event_info);
> +static inline void libpqsrv_notice_receiver(void *arg, const PGresult *res);
> 
> This prototype is only needed if the function is used earlier in libpq-be-fe-helpers.h,
> but that's not the case here, so I don't think it's necessary.
> 
> Unless there are objections, I'll remove that prototype and commit the patch.

LGTM.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
 algunas personas nos parecen brillantes un minuto antes
 de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: Missing NULL check after calling ecpg_strdup
Next
From: vignesh C
Date:
Subject: Re: Logical Replication of sequences