Re: pg_dump does not dump domain not-null constraint's comments - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: pg_dump does not dump domain not-null constraint's comments
Date
Msg-id 202507171704.ksylf7ifwbz6@alvherre.pgsql
Whole thread Raw
In response to Re: pg_dump does not dump domain not-null constraint's comments  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
On 2025-Jul-15, jian he wrote:

> we should let:
> dumpConstraint handles dumping separate "NOT VALID" domain constraints along
> with their comments.
> dumpDomain: handles dumping "inlined" valid (not separate) domain constraints
> together with their comments.

Hmm, okay, but not-null constraints on domain cannot be NOT VALID at
present.  I think it would be a useful feature (so that users can make
domains not-null that are used in tables already populated with data),
but first you'd need to implement things so that each table has a
not-null constraint row for the column whose type is the domain that's
being marked not-null.

Anyway, here's a patch.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: simple patch for discussion
Next
From: Masahiko Sawada
Date:
Subject: Re: Conflict detection for update_deleted in logical replication