Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore
Date
Msg-id 202504141220.343fmoxfsbj4@alvherre.pgsql
Whole thread Raw
Responses Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore
List pgsql-hackers
On 2025-Apr-04, Andrew Dunstan wrote:

> Non text modes for pg_dumpall, correspondingly change pg_restore

I think the new oid_string_list stuff in this commit is unnecessary, and
we can remove a bunch of lines by simplifying that to using
SimplePtrList, as the attached illustrates.  (Perhaps the names of
members of the proposed struct can be improved.)

I also propose to remove the open-coded implementation of pg_get_line.

WDYT?

I'm also not sure about the double sscanf() business there ... There
must be a better way to do this.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/

Attachment

pgsql-hackers by date:

Previous
From: Kirill Reshke
Date:
Subject: Re: support create index on virtual generated column.
Next
From: Matheus Alcantara
Date:
Subject: Re: New committer: Jacob Champion