Question about comments on simple_heap_update - Mailing list pgsql-hackers

From Yugo Nagata
Subject Question about comments on simple_heap_update
Date
Msg-id 20250331204402.784a75f11c38aa9b6c0accc0@sraoss.co.jp
Whole thread Raw
List pgsql-hackers
Hi,

While working on [1], I found the internal error "tuple concurrently updated"
is raised by simple_heap_update and other similar functions, and the comments
on them says "Any failure is reported via ereport()". However, I could not understand
the intension of this comments because I suppose the unexpected errors are usual
reported via elog() not ereport and in fact elog() is used in these functions. 

I wonder this statement should be fixed as the attached patch or could be removed for
less confusion. Maybe, I am just missing something, though....
 

[1] https://www.postgresql.org/message-id/flat/20250331200057.00a62760966a821d484ea904%40sraoss.co.jp

-- 
Yugo Nagata <nagata@sraoss.co.jp>

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: per backend WAL statistics
Next
From: Fabien COELHO
Date:
Subject: Add partial :-variable expansion to psql \copy