Re: pg_dump and schema names - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump and schema names
Date
Msg-id 20250.1376067200@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump and schema names  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_dump and schema names  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Fri, Aug  9, 2013 at 01:48:43AM -0400, Tom Lane wrote:
>> The practical difficulties involved can be seen by reading the comments
>> and code for _getObjectDescription().

> Yes, I looked at that.    Seems _getObjectDescription() is only called
> from _printTocEntry(), and that function has a call to
> _selectOutputSchema() at the top, so we already know we have search_path
> set to the proper schema.

> The attached patch removes the unnecessary schema qualification for
> ALTER OWNER, and the attached dump file show a two-schema dump that
> restores just fine.

This really requires more than no attention to the comments, especially
since you just removed the only apparent reason for _getObjectDescription
to make a distinction between objects whose name includes a schema and
those that don't.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: question about HTTP API
Next
From: Craig Ringer
Date:
Subject: Re: confusing error message