strangely worded message - Mailing list pgsql-hackers

From Alvaro Herrera
Subject strangely worded message
Date
Msg-id 202412141243.efesjyyvzxsz@alvherre.pgsql
Whole thread Raw
Responses Re: strangely worded message
List pgsql-hackers
Hello

The following message introduced by commit 03734a7fed7d appears in two
places:

        if (returning->typid != JSONOID && returning->typid != JSONBOID)
            ereport(ERROR,
                    (errcode(ERRCODE_DATATYPE_MISMATCH),
                     errmsg("cannot use RETURNING type %s in %s",
                            format_type_be(returning->typid), fname),
                     parser_errposition(pstate, output->typeName->location)));

where fname is either JSON(), JSON_SCALAR(), JSON_SERIALIZE().  The
wording seems a bit off to me.  What about the following?

ERROR:  cannot use type %s in RETURNING clause of %s
DETAIL:  Only types json and jsonb are allowed in the RETURNING clause.

Other ideas I considered:

ERROR:  cannot use RETURNING %s in %s
ERROR:  cannot use "RETURNING %s" in %s

DETAIL:  The type can be json or jsonb in RETURNING.
DETAIL:  The RETURNING clause allows types json or jsonb.
DETAIL:  Types json and jsonb are allowed in RETURNING.

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Ryo Kanbayashi
Date:
Subject: Re: typo in a comment of restrictinfo.c
Next
From: Junwang Zhao
Date:
Subject: Re: SQL Property Graph Queries (SQL/PGQ)