Re: Better error message when --single is not the first arg to postgres executable - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Better error message when --single is not the first arg to postgres executable
Date
Msg-id 202412031722.v3jlfbllozqc@alvherre.pgsql
Whole thread Raw
In response to Better error message when --single is not the first arg to postgres executable  (Greg Sabino Mullane <htamfids@gmail.com>)
List pgsql-hackers
On 2024-Dec-03, Nathan Bossart wrote:

> +Subprogram
> +parse_subprogram(const char *name)
> +{

Please add a comment atop this function.  Also, I don't think it should
go at the end of the file; maybe right after main() is a more
appropriate location?

> +/* special must-be-first options for dispatching to various subprograms */
> +typedef enum Subprogram
> +{

I'm not sure this comment properly explains what this enum is used for.
Maybe add a reference to parse_subprogram to the comment?

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Al principio era UNIX, y UNIX habló y dijo: "Hello world\n".
No dijo "Hello New Jersey\n", ni "Hello USA\n".



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: crash with synchronized_standby_slots
Next
From: Tom Lane
Date:
Subject: Re: Remove useless casts to (void *)