Re: pgsql: Skip some permissions checks on Cygwin - Mailing list pgsql-committers

From Noah Misch
Subject Re: pgsql: Skip some permissions checks on Cygwin
Date
Msg-id 20240624010311.0b.nmisch@google.com
Whole thread Raw
In response to pgsql: Skip some permissions checks on Cygwin  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Skip some permissions checks on Cygwin
List pgsql-committers
On Thu, Jun 13, 2024 at 12:12:29PM +0000, Andrew Dunstan wrote:
> Skip some permissions checks on Cygwin
> 
> These are checks that are already skipped on other Windows systems.

>      skip "unix-style permissions not supported on Windows", 2
> -      if ($windows_os);
> +      if ($windows_os || $Config::Config{osname} eq 'cygwin');

> -    skip "group access not supported on Windows", 3 if ($windows_os);
> +    skip "group access not supported on Windows", 3
> +      if ($windows_os || $Config::Config{osname} eq 'cygwin');

Cygwin does support Unix-style permissions, so I'm not following the rationale
for this change.  Can you say more?



pgsql-committers by date:

Previous
From: Alexander Korotkov
Date:
Subject: pgsql: Remove extra comment at TableAmRoutine.scan_analyze_next_block
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Translation updates