Re: pgsql: Enhance libpq encryption negotiation tests with new GUC - Mailing list pgsql-committers

At Sun, 07 Apr 2024 23:50:08 +0000, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote in 
> Enhance libpq encryption negotiation tests with new GUC

This commit adds the following messages:

> gettext_noop("Log details of pre-authentication connection handshake."),

Similar to a nearby commit, other messages with a similar context use
the phrase "Logs <something>". Wouldn't it be better to align this
message with existing ones?

diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 83e3a59d7e..4584829992 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -1227,7 +1227,7 @@ struct config_bool ConfigureNamesBool[] =
     },
     {
         {"trace_connection_negotiation", PGC_POSTMASTER, DEVELOPER_OPTIONS,
-            gettext_noop("Log details of pre-authentication connection handshake."),
+            gettext_noop("Logs details of pre-authentication connection handshake."),
             NULL,
             GUC_NOT_IN_SAMPLE
         },

regards

-- 
Kyotaro Horiguchi
NTT Open Source Software Center