RE: pg_dump not dumping the run_as_owner setting from version 16? - Mailing list pgsql-hackers

From Philip Warner
Subject RE: pg_dump not dumping the run_as_owner setting from version 16?
Date
Msg-id 20231028085427.5DA3A220F0B@thebes.rime.com.au
Whole thread Raw
In response to Re: pg_dump not dumping the run_as_owner setting from version 16?  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: pg_dump not dumping the run_as_owner setting from version 16?
List pgsql-hackers

...patch actually attached this time...


> > I as far as I can tell, pg_dump does not dup the ‘run_as_owner` setting for a subscription.

> >

> > Should it? Should I submit a patch? It seems pretty trivial to fix if anyone else is working on it.

>

> Yes, it certainly should.  That is an omission in 482675987b.

> Go ahead and write a fix!

 

Please find attached a patch for pg_dump to honour the setting of `run_as_owner`; I believe that effective pre-16 behavious was to run as owner, so I have set the flag to ‘t’ for pre-16 versions. Please let me know if you would prefer the opposite.

 

 

> > Further to this: it seems that `Alter Subscription X Set(Run_As_Owner=True);`

> > has no influence on the `subrunasowner` column of pg_subscriptions.

>

> This seems to have been fixed in f062cddafe.

 

Yes, I can confirm that in the current head `pg_subscriptions` reflects the setting correctly.

Attachment

pgsql-hackers by date:

Previous
From: Laurenz Albe
Date:
Subject: Re: unnest multirange, returned order
Next
From: John Naylor
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum