Re: broken master regress tests - Mailing list pgsql-hackers

From Andres Freund
Subject Re: broken master regress tests
Date
Msg-id 20231011005434.34oc4v4pv6ajqkss@awork3.anarazel.de
Whole thread Raw
In response to Re: broken master regress tests  (Jeff Davis <pgsql@j-davis.com>)
Responses Re: broken master regress tests
Re: broken master regress tests
List pgsql-hackers
Hi,

On 2023-10-10 17:08:25 -0700, Jeff Davis wrote:
> On Mon, 2023-09-11 at 19:23 -0700, Andres Freund wrote:
> > > So I think injecting --no-locale to the initdb line that creates
> > > the
> > > template is a better approach; something like the attached.
> > 
> > Makes sense, thanks for taking care of this.
> 
> After this, it seems "make check" no longer picks up the locale from
> the system environment by default.

Yea. I wonder if the better fix would have been to copy setenv("LC_MESSAGES", "C", 1);
to the initdb template creation. That afaict also fixes the issue, with a
smaller blast radius?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: PGDOCS - add more links in the pub/sub reference pages
Next
From: Jeff Davis
Date:
Subject: Re: Pre-proposal: unicode normalized text