Re: Annoying build warnings from latest Apple toolchain - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Annoying build warnings from latest Apple toolchain
Date
Msg-id 20230930193700.azbic3gv3uoj23mx@alap3.anarazel.de
Whole thread Raw
In response to Re: Annoying build warnings from latest Apple toolchain  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2023-09-30 13:28:01 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2023-09-29 12:14:40 -0400, Tom Lane wrote:
> >> Looking closer, it's only since v16 that we have export list support
> >> on all officially-supported platforms.
> 
> > Oh, right, before that Solaris didn't support it. I guess we could backpatch
> > that commit, it's simple enough, but I don't think I care enough about Solaris
> > to do so.
> 
> HPUX would be an issue too, as we never did figure out how to do
> export control on that.

Ah, right.


> However, I doubt it would be a great idea
> to back-patch export control in minor releases, even if we had
> the patch at hand.  That would be an ABI break of its own, although
> it'd only affect clients that hadn't done things quite correctly.

Agreed.


> >> Therefore, I think the prudent thing to do in the back branches is use the
> >> patch I posted before, to suppress the duplicate -l switches only on macOS.
> >> In HEAD, I propose we simplify life by doing it everywhere, as attached.
> 
> > Makes sense.
> 
> Done that way.  Were you going to push the -Wl,-exported_symbols_list
> change?

Done now.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: SHARED locks barging behaviour
Next
From: Andres Freund
Date:
Subject: Re: Annoying build warnings from latest Apple toolchain