Re: Add PG CI to older PG releases - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Add PG CI to older PG releases
Date
Msg-id 20230810230054.2wueghoqivf2kc6n@awork3.anarazel.de
Whole thread Raw
In response to Re: Add PG CI to older PG releases  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: Add PG CI to older PG releases
List pgsql-hackers
Hi,

On 2023-08-10 19:55:15 +0300, Nazir Bilal Yavuz wrote:
> v2-0001-windows-Only-consider-us-to-be-running-as-service.patch is an
> older commit (59751ae47fd43add30350a4258773537e98d4063). A couple of
> tests were failing without this because the log file was empty and the
> tests were comparing strings with the log files (like in the first
> mail).

Hm. I'm a bit worried about backpatching this one, it's not a small
behavioural change. But the prior behaviour is pretty awful and could very
justifiably be viewed as a bug.

At the very least this would need to be combined with

commit 950e64fa46b164df87b5eb7c6e15213ab9880f87
Author: Andres Freund <andres@anarazel.de>
Date:   2022-07-18 17:06:34 -0700

    Use STDOUT/STDERR_FILENO in most of syslogger.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication
Next
From: Andres Freund
Date:
Subject: Re: Add PG CI to older PG releases