Re: [PATCH] Missing dep on Catalog.pm in meson rules - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Missing dep on Catalog.pm in meson rules
Date
Msg-id 20230616211628.3wxxt2cisexqrakq@awork3.anarazel.de
Whole thread Raw
In response to Re: [PATCH] Missing dep on Catalog.pm in meson rules  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCH] Missing dep on Catalog.pm in meson rules
List pgsql-hackers
Hi,

On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote:
> Unless I'm misunderstanding, this doesn't look terribly feasible to me. You
> can only get at %INC by loading the module, which in many cases will have
> side effects.

I was envisioning using %INC after the use/require block - I don't think our
scripts load additional modules after that point?


> And then you would also need to filter out things loaded that
> are not our artefacts (e.g. Catalog.pm loads File::Compare).

I don't think we would need to filter the output. This would just be for a
build dependency file. I don't see a problem with rerunning genbki.pl et al after
somebody updates File::Compare?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Adding further hardening to nbtree page deletion
Next
From: David Zhang
Date:
Subject: Re: [PATCH] pg_regress.c: Fix "make check" on Mac OS X: Pass DYLD_LIBRARY_PATH