Re: Consistent coding for the naming of LR workers - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Consistent coding for the naming of LR workers
Date
Msg-id 20230616.104327.1878440413098623268.horikyota.ntt@gmail.com
Whole thread Raw
In response to Consistent coding for the naming of LR workers  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
At Thu, 15 Jun 2023 12:42:33 +1000, Peter Smith <smithpb2250@gmail.com> wrote in 
> It is better to have a *single* point where these worker names are
> defined, so then all output uses identical LR worker nomenclature.
> 
> PSA a small patch to modify the code accordingly. This is not intended
> to be a functional change - just a code cleanup.
> 
> Thoughts?

I generally like this direction when it actually decreases the number
of translatable messages without making grepping on the tree
excessively difficult. However, in this case, the patch doesn't seems
to reduce the translatable messages; instead, it makes grepping
difficult.

Addition to that, I'm inclined to concur with Alvaro regarding the
gramattical aspect.

Consequently, I'd prefer to leave these alone.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: subscription/033_run_as_table_owner is not listed in the meson.build
Next
From: Amit Kapila
Date:
Subject: Re: Non-superuser subscription owners