Re: When to drop src/tools/msvc support - Mailing list pgsql-hackers

From Andres Freund
Subject Re: When to drop src/tools/msvc support
Date
Msg-id 20230411175704.xj2cbcnnmq4yxreq@awork3.anarazel.de
Whole thread Raw
In response to Re: When to drop src/tools/msvc support  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: When to drop src/tools/msvc support  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2023-04-11 13:30:15 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Here's a draft docs change.
> 
> > I added the <warning/> in two places in install-windows.sgml so it's visible
> > on both the generated pages in the chunked output. That does mean it's visible
> > twice nearby in the single-page output, but I don't think that's commonly
> > used.
> 
> I don't agree with placing that first hunk before the para that tells
> people to use a binary distribution, as it's completely irrelevant
> if they take that advice.

Fair point.


> I'm not really sure we need it at all, because quite a bit of the text right
> after that is not specific to using the src/tools/msvc scripts either.  I
> think the <warning> under "Building with <productname>Visual
> C++</productname> ..." is sufficient.

It seemed nicer to have it on all the "Installation from Source Code on Windows"
pages, but...

Except that we're planning to remove it anyway, the structure of the docs here
seems a bit off...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Direct I/O
Next
From: Andres Freund
Date:
Subject: Re: Should we remove vacuum_defer_cleanup_age?