Re: Combine pg_walinspect till_end_of_wal functions with others - Mailing list pgsql-hackers

Hi,

I just rebased a patch over

commit 1f282c24e46
Author: Michael Paquier <michael@paquier.xyz>
Date:   2023-03-13 13:03:29 +0900
 
    Refactor and improve tests of pg_walinspect

and got a test failure:

https://cirrus-ci.com/task/5693041982308352

https://api.cirrus-ci.com/v1/artifact/task/5693041982308352/testrun/build/testrun/pg_walinspect/regress/regression.diffs

diff -w -U3 C:/cirrus/contrib/pg_walinspect/expected/oldextversions.out
C:/cirrus/build/testrun/pg_walinspect/regress/results/oldextversions.out
--- C:/cirrus/contrib/pg_walinspect/expected/oldextversions.out    2023-03-14 21:19:01.399716500 +0000
+++ C:/cirrus/build/testrun/pg_walinspect/regress/results/oldextversions.out    2023-03-14 21:26:27.504876700 +0000
@@ -8,10 +8,10 @@
                     Object description
 -----------------------------------------------------------
  function pg_get_wal_record_info(pg_lsn)
- function pg_get_wal_records_info(pg_lsn,pg_lsn)
  function pg_get_wal_records_info_till_end_of_wal(pg_lsn)
- function pg_get_wal_stats(pg_lsn,pg_lsn,boolean)
+ function pg_get_wal_records_info(pg_lsn,pg_lsn)
  function pg_get_wal_stats_till_end_of_wal(pg_lsn,boolean)
+ function pg_get_wal_stats(pg_lsn,pg_lsn,boolean)
 (5 rows)

 -- Make sure checkpoints don't interfere with the test.

Looks like it's missing an ORDER BY.

Greetings,

Andres Freund