Re: BUG #17777: An assert failed in nodeWindowAgg.c - Mailing list pgsql-bugs

From Andres Freund
Subject Re: BUG #17777: An assert failed in nodeWindowAgg.c
Date
Msg-id 20230213004633.udoooi3gabxvtfbw@awork3.anarazel.de
Whole thread Raw
In response to Re: BUG #17777: An assert failed in nodeWindowAgg.c  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: BUG #17777: An assert failed in nodeWindowAgg.c  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-bugs
Hi,

On 2023-02-13 13:31:54 +1300, David Rowley wrote:
> On Mon, 13 Feb 2023 at 05:19, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Why is it okay to check only the filter, and not the rest of the
> > WindowFunc's subexpressions?  The arguments we've just run through
> > seem to apply to a subplan in the direct or aggregated arguments
> > as well.
> 
> Good point.  I had just been thinking in terms of the reported bug to
> make sure we inverse transition the same rows we transition. We also
> need to make sure the transition value matches in both transition
> directions.

What about find_compatible_agg()? I don't think there's as severe
consequences, but it also doesn't seem right as-is.

Greetings,

Andres Freund



pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: BUG #17777: An assert failed in nodeWindowAgg.c
Next
From: Tom Lane
Date:
Subject: Re: BUG #17777: An assert failed in nodeWindowAgg.c